Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit "disposed" event on Component dispose #299

Merged
merged 2 commits into from
Nov 21, 2017
Merged

Emit "disposed" event on Component dispose #299

merged 2 commits into from
Nov 21, 2017

Conversation

p2kmgcl
Copy link
Contributor

@p2kmgcl p2kmgcl commented Nov 17, 2017

No description provided.

@jbalsas
Copy link
Contributor

jbalsas commented Nov 17, 2017

Hey @p2kmgcl, thanks for sending this over!

Could you please open an issue explaining the motivation for the new feature? We are auto-generating the CHANGELOG for releases, and just merging PRs doesn't give us all the information we need :)

Thanks!

@p2kmgcl
Copy link
Contributor Author

p2kmgcl commented Nov 17, 2017

@jbalsas done

@robframpton robframpton changed the base branch from master to develop November 21, 2017 22:16
@robframpton robframpton merged commit 0b84b2e into metal:develop Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants