-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that STATE configuration from static hints are properly configured with multiple levels of class inheritance #288
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1041,6 +1041,32 @@ describe('State', function() { | |
assert.strictEqual('foo2', test2.key1); | ||
assert.strictEqual('foo1', test1.key1); | ||
}); | ||
|
||
it('should configure static STATE with multiple levels of class inheritance', function() { | ||
var Test = createTestClass(); | ||
Test.STATE = { | ||
key1: { | ||
} | ||
}; | ||
|
||
class Child extends Test { | ||
} | ||
Child.STATE = { | ||
key2: { | ||
} | ||
}; | ||
|
||
var test = new Test({ | ||
key1: 'foo1' | ||
}); | ||
assert.strictEqual('foo1', test.key1); | ||
|
||
var child = new Child({ | ||
key2: 'foo2' | ||
}); | ||
assert.strictEqual('foo1', test.key1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this be asserting There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, if you change it to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No, it's shouldn't be asserting There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, I see! For some reason I assumed they had defaults! |
||
assert.strictEqual('foo2', child.key2); | ||
}); | ||
}); | ||
|
||
describe('Separate object', function() { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible typo
form
->from
?