Check to see if bundle has been loaded already. Fixes #273

[robframpton]

No description provided.

[jbalsas]

Hey @Robert-Frampton, this looks good in general, I just have one question. Even though I tweaked the metal-soy-bundle build, I quite never remember how it is setup and what is what 😂.

What is the difference between metal-soy-bundle/build/bundle.js and metal-soy-bundle/lib/bundle.js? Shouldn't we try to load lib twice instead of lib/bundle.js and build/bundle.js?

While we're at this... could we add some information in metal-soy-bundle/README.md clarifying for future reference?

[robframpton]

Hey @jbalsas

build/bundle.js is just the concatenated files, nothing more. That file is then transpiled which generates lib/bundle.js.

The reason I loaded the build/bundle.js file in the test, is that Karma has some kind of mechanism for making sure a file is loaded only once, so I couldn't get it to load a second time when pointing to lib/bundle.js.

And yes, we can add some readme info on the build process :)

[jbalsas]

I see... and couldn’t we trick Karma with some kind of cache querystring? &t=123?

[robframpton]

That's what I tried actually, didn't have any affect on it.

[robframpton]

Added a short description of the build process.

[jbalsas]

Hey @Robert-Frampton, looks like this actually broke some tests when merged 😢. I'm trying to see why the merge tests are not running in Travis (only the PR ones).

In the meantime, I can revert this so we can process the others, or you can send a followup PR fixing it. What would you prefer? 🤷‍♂️

[yuchi]

Question: does the solution to the issue at hand make impossible to have multiple Metal.js versions in the same page? Hint: it’s going to happen when deploying modern bundles to portal built with different metal version.

[jbalsas]

Hey @yuchi, that's actually a very interesting question indeed... I don't think it has ever been possible, because both incr-dom and soy-bundle leak to the global scope.

We're going to revert it in any case. We can rather approach this with that in mind. It would involve touching both incr-dom and soy-bundle, so we'll have to plan that for some later time...