Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export HTMLParser rather than attaching to window #274

Merged
merged 3 commits into from
Oct 11, 2017

Conversation

robframpton
Copy link

No description provided.

@robframpton
Copy link
Author

I haven't been able to reproduce these test failures locally, not sure what's going on.

@jbalsas
Copy link
Contributor

jbalsas commented Oct 11, 2017

Hey @Robert-Frampton, I'm getting the same error as in Travis if I clean up the project before runing the tests. My steps:

$ find . -name node_modules -type d -exec rm -rf {} +
$ npm run lerna
$ npm run test

@jbalsas
Copy link
Contributor

jbalsas commented Oct 11, 2017

I think you might've failed to commit the new entry point?

@robframpton
Copy link
Author

Strange, I cleaned mine a couple of times and got the same results, but you're right, the entry point didn't get committed :(

@robframpton
Copy link
Author

Alright, I addressed the merge conflicts and fixed the entry point. Tests are running now.

@jbalsas jbalsas merged commit 12fe8a7 into metal:develop Oct 11, 2017
@jbalsas jbalsas added this to the 2.14.0 milestone Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants