Add willReceiveState and willReceiveProps lifecycle methods to Component and JSXComponent respectively #270
Conversation
| @@ -172,6 +182,8 @@ class Component extends EventEmitter { | |||
| */ | |||
| attach(opt_parentElement, opt_siblingElement) { | |||
| if (!this.inDocument) { | |||
| this.emit('willAttach'); | |||
| this.willAttach(); | |||
There was a problem hiding this comment.
Hey @Robert-Frampton, based on componentWillMount():
componentWillMount()is invoked immediately before mounting occurs. It is called before render(), therefore setting state synchronously in this method will not trigger a re-rendering. Avoid introducing any side-effects or subscriptions in this method.
Can we assume the same with this?
There was a problem hiding this comment.
Hey @jbalsas
So an area where Metal is already different than React is that our render actually happens before attach. This is how the lifecycle is ordered on first render.
created > willRender > rendered > willAttach > attached > willDetach > detached > disposed
I think the only way we can mirror React completely is to do a breaking change and change the order so that attachment happens before render, but obviously we can't do that for 2.14. Although we could move willAttach only, but it feels weird to me.
created > willAttach > willRender > rendered > attached > willDetach > detached > disposed.
There was a problem hiding this comment.
That's fine for now... I think we are entitled to some little quirks of our own ;)
I think we just need to improve our Component Lifecycle documentation so everything is clear :)
| @@ -501,6 +527,9 @@ class Component extends EventEmitter { | |||
| * be called manually later to actually attach it to the dom. | |||
| */ | |||
| renderComponent(opt_parentElement) { | |||
| const firstRender = !this.hasRendererRendered_; | |||
| this.emit('willRender', firstRender); | |||
| this.willRender(firstRender); | |||
There was a problem hiding this comment.
Based on componentWillUpdate(), the signature for this method should be:
componentWillUpdate(nextProps, nextState)Furthermore:
componentWillUpdate()is invoked immediately before rendering when new props or state are being received. Use this as an opportunity to perform preparation before an update occurs. This method is not called for the initial render.
Finally, do we have the last note in mind?
componentWillUpdate()will not be invoked if shouldComponentUpdate() returns false.
There was a problem hiding this comment.
I update this in the new pull. I changed the name to willUpdate since it's closely related to shouldUpdate and receives the same arguments.
See #255