Issue/209 #231
Merged
Issue/209 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/metal-dom/src/domNamed.js
Outdated
| @@ -340,7 +340,18 @@ export function hasClass(element, className) { | |||
| * @private | |||
| */ | |||
| function hasClassWithNative_(element, className) { | |||
| return element.classList.contains(className); | |||
| try { | |||
There was a problem hiding this comment.
try/catch won't be optimized in browsers, would be better to check for presence of element.classList.
|
Ok, I have updated my PR and:
|
|
Hey @Robert-Frampton, this should be good to go. Care to take a look and merge if all seems fine? Thanks! |
|
Why not remove the try catch block and check for whitespace in function hasClassWithNative_(element, className) {
return className.indexOf(' ') < 0 && element.classList.contains(className);
}That way there is no error to catch. |
|
@Robert-Frampton you are totally right. I will modify the PR and notify you in a couple of days. Thanks for the correction :) |
added 2 commits
August 24, 2017 13:02
Now the pass the given test. For the case of hasClassWithNative_, it tries to use the native methods, but catches a dom exception with the text "contains HTML space characters", other exceptions are thrown.
|
@Robert-Frampton ready to go |
|
LGTM. |
|
Hey guys, should we close #209 as well? |
|
Yeah, done! 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits solve the report described con #209, however, there are three things pending before finishing:
MDN DOMException docs: https://developer.mozilla.org/en-US/docs/Web/API/DOMException
MSDN DOMException docs: https://msdn.microsoft.com/es-es/library/ff974354(v=vs.85).aspx