Improve metal-soy-bundle build #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncat them in the proper order
|
On top of this I have c2ab5b0 which should support the new compiler and seems to be backwards compatible. I'm testing right now... fingers crossed! |
|
Hey guys, I've tested this on several @eduardolundgren, @Robert-Frampton, @brunobasto, @fernandosouza, do you have any comments? I'll merge it later today otherwise 😉 |
|
LGTM @jbalsas. |
|
Sorry, I've pushed the wrong button. ^^ |
robframpton
approved these changes
Mar 30, 2017
|
Just FYI, I've pushed an additional commit ignoring the whole package from linting intents: 6633b3c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple attempt at making some sense of the build process of
metal-soy-bundle. I tracked all the pasted snippets to their correspondingclosure-libraryandclosure-templatesmodules so future diffing is easier.The
bundle.jsresult file is exact to the old one other than some white spaces and it passes all the tests in metal.js.