Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exports Config from metal-soy #208

Merged
merged 1 commit into from
Feb 8, 2017

Conversation

mthadley
Copy link

@mthadley mthadley commented Feb 7, 2017

This exports Config from metal-soy in the same way that we do in metal-jsx.

Also, I wonder if going forward we should encourage using Config instead of doing something like validator: core.isString. Config seems to be more concise, and provide better feedback (in the form of warnings) when you provide invalid props. It's also more expressive and self-documenting when you need to validate enumerations (oneOf).

@eduardolundgren
Copy link
Contributor

For consistency I think it's a good addition. I will merge it, let me know if anyone has any concern.

/cc @mairatma

@eduardolundgren eduardolundgren merged commit 6ecd4ac into metal:master Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants