Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes array.equal a little bit faster in case both arrays point to the same reference #203

Merged
merged 2 commits into from
Jan 30, 2017
Merged

Makes array.equal a little bit faster in case both arrays point to the same reference #203

merged 2 commits into from
Jan 30, 2017

Conversation

brunobasto
Copy link

No description provided.

@brunobasto brunobasto requested a review from jbalsas January 27, 2017 01:36
@eduardolundgren
Copy link
Contributor

Could you add a test for that?

@brunobasto
Copy link
Author

It doesn't really change any behavior, other than performance. Not sure how to write a test for that.

@eduardolundgren
Copy link
Contributor

It's for coverage purpose.

@brunobasto
Copy link
Author

@eduardolundgren, that makes total sense. I've added the test. Thx!

@eduardolundgren eduardolundgren merged commit c52b1e9 into metal:master Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbalsas jbalsas Awaiting requested review from jbalsas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brunobasto @eduardolundgren