Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metal-dom] domNamed.contains isn't working on IE11 when I pass document as first argument #401

Closed
diegonvs opened this issue Nov 21, 2018 · 0 comments
Closed

[metal-dom] domNamed.contains isn't working on IE11 when I pass document as first argument #401

diegonvs opened this issue Nov 21, 2018 · 0 comments

Comments

@diegonvs
Copy link
Contributor

If you try use document.contains(document.querySelector('link')) on IE11 the browser returns the following message:

Object doesn't support property or method 'contains'

domNamed implementation of contains just follow browser implementation.

PS: Using IE11 with old Trident engine, that comes default on latest Windows 7 or Windows 8.1 builds.
diegonvs added a commit to diegonvs/metal.js that referenced this issue Nov 21, 2018
@diegonvs
Fixes metal#401 | Use assert isTrue and isFalse instead of ok
c09935f
jbalsas added a commit that referenced this issue Nov 28, 2018
@jbalsas
Merge pull request #402 from diegonvs/401
b7c606a 
Fixes #401 | Revert deprecation of contains function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@diegonvs