Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IncrementalDOMRenderer render function can fall when a component created from a different version is passed #349

Closed
robframpton opened this issue Jan 26, 2018 · 0 comments

Comments

@robframpton
Copy link

The code in question.

render(component, dataOrElement, parent) {
	// If the passed `component` comes from a different version of metal-component than `Component` this check will fail
	if (component instanceof Component) {
		this.patch(component);
	} else {
		return renderFunction(this, component, dataOrElement, parent);
	}
}
jbalsas added a commit that referenced this issue Jan 26, 2018
Replace instanceof check with check for COMPONENT_FLAG | Fixes #349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant