Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values are being overwritten by undefined prop values if state of parent component is updated [metal-jsx] #345

Closed
kienD opened this issue Jan 24, 2018 · 0 comments

Comments

@kienD
Copy link
Contributor

kienD commented Jan 24, 2018

This issue is related to #259 .

The default value for props of a child component will be overwritten by the values passed in from the parent component once the state of the parent component changes. This is even if the value is undefined.

I would expect the default value for props of the child component to take precedence over an undefined value regardless of if it was on the first render or another render later on.

I sent pr for the broken test as well. #346

kienD pushed a commit to kienD/metal.js that referenced this issue Jan 24, 2018
kienD pushed a commit to kienD/metal.js that referenced this issue Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant