Updates "isString" to also accept String instances

metal · Aug 8, 2016 · e26b84f · e26b84f
1 parent f1e8847
commit e26b84f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/metal/src/core.js b/packages/metal/src/core.js
@@ -187,10 +187,10 @@ class core {
 	/**
 	 * Returns true if value is a string.
 	 * @param {*} val
-	 * @return {Boolean}
+	 * @return {boolean}
 	 */
 	static isString(val) {
-		return typeof val === 'string';
+		return typeof val === 'string' || val instanceof String;
 	}
 
 	/**

diff --git a/packages/metal/test/core.js b/packages/metal/test/core.js
@@ -171,6 +171,7 @@ describe('core', function() {
 			assert.ok(!core.isString(undefined));
 
 			assert.ok(core.isString(''));
+			assert.ok(core.isString(new String(''))); // jshint ignore:line
 		});
 
 		it('should check if var is boolean', function() {