External msg format #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthadley
approved these changes
May 25, 2017
matuzalemsteles
pushed a commit
to matuzalemsteles/metal-tools-soy
that referenced
this pull request
Aug 27, 2018
…ffer as argument - Fixes metal#12
diegonvs
pushed a commit
to diegonvs/metal-tools-soy
that referenced
this pull request
Nov 26, 2018
…ffer as argument - Fixes metal#12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @eduardolundgren, @mthadley, this PR adds support for an
externalMsgFormatoption that can be used to replace the extracted messages by the soy compiler.For example, for
externalMsgFormat: "I18n.translate('$2').replace('a', 'A')"it would turn generated output like:into
We are currently doing this via
Gradleafter all the compile steps have happened in https://github.com/liferay/liferay-portal/blob/master/modules/util/portal-tools-soy-builder/src/main/java/com/liferay/portal/tools/soy/builder/commands/ReplaceSoyTranslationCommand.java, but it would be nice if we could do it in just one step while we're compiling soy so we can also make sure changes in the compiler won't break client code.What do you think?