Integrate new metal/soyparser #11
Conversation
lib/pipelines/compileSoy.js
Outdated
| } | ||
|
|
||
| // Parse inner params | ||
| template.params.forEach(extractParam); |
There was a problem hiding this comment.
@mthadley, could template.params be null?
There was a problem hiding this comment.
@jbalsas Nope, you should be good here: https://github.com/metal/soyparser/blob/master/src/types.ts#L217 👍
lib/pipelines/compileSoy.js
Outdated
| if (cmd.deltemplate) { | ||
|
|
||
| parsed.body.forEach(function(template) { | ||
| if (template.deltemplate) { |
There was a problem hiding this comment.
I think this will always be false, since neither Template or DelTemplate have a deltemplate field. If the intent is to skip these, you can check if template.type === 'DelTemplate'.
There was a problem hiding this comment.
Makes sense, yeah, didn't think about it. Will update it and add a test for it, thanks!
lib/pipelines/compileSoy.js
Outdated
| return; | ||
| } | ||
|
|
||
| var templateName = cmd.name; | ||
| var templateName = template.id.name; |
There was a problem hiding this comment.
Just be aware that this will only be something like .render, and namespace is a separate attribute on id.
There was a problem hiding this comment.
True... I'll double check to see what were we getting before. Thanks!
|
Hey @mthadley, I've added a test for the Could you please take a final look? Thanks! |
|
Merged, thanks @mthadley! |
This PR updates support to use the newer metal/soyparser