Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UI more responsive and CSS cleanup #92

Merged
merged 22 commits into from
Jan 11, 2025

Conversation

uday-kalyan-s
Copy link
Contributor

@uday-kalyan-s uday-kalyan-s commented Dec 9, 2024

duplicate of #89 (comment) because it got wiped out cleaning commit history

  • remove redundant properties
  • remove !important tags to make it more maintainable and fix rendering issues on chrome mobile
  • Make UI more responsive
  • fix the issue of long names in the table caption(try "Arun Kumar Samantaray")

@uday-kalyan-s uday-kalyan-s mentioned this pull request Dec 9, 2024
3 tasks
@uday-kalyan-s
Copy link
Contributor Author

hello @harshkhandeparkar . I'm done with the work. Can I please get a review and merge it?

@harshkhandeparkar
Copy link
Member

@uday-kalyan-s Please rebase the PR. Also, can you send a few screenshots at different screen sizes?

@uday-kalyan-s
Copy link
Contributor Author

hello @harshkhandeparkar . i have rebased it. can you please review it now

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like reading CSS. We'll test it in prod.

@harshkhandeparkar harshkhandeparkar merged commit 41e30d2 into metakgp:master Jan 11, 2025
@harshkhandeparkar
Copy link
Member

Looks fine. However, perhaps the TT height can be reduced on mobile.

@uday-kalyan-s
Copy link
Contributor Author

uday-kalyan-s commented Jan 11, 2025

uhh how was this closed? I dont have to make a new PR right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants