Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Admin Page frontend #67

Merged
merged 46 commits into from
Aug 25, 2024

Conversation

Majestic9169
Copy link
Contributor

@Majestic9169 Majestic9169 commented Jun 4, 2024

Tasks

  • create table to list question papers
  • make question paper details editable
  • add efficient aprove/reject mechanism
  • make table sortable by all fields
  • filter capability based on approval status (this is redundant by making the table sortable)
  • show approved by/rejected by
  • modal to view pdf (optional)

Issues

  • data validation between course names and course codes
  • unable to style focused element in solid-select (found the element but still unable to style it the way I want)
  • unable to style disabled element

Fixes #63

create dummy data to display
create PDFtable and PDFListElement components
create IAdminResult interface
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
iqps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2024 5:22pm

left click to approve, click again to mark pending
right click to reject, click again to mark pending
alt + z toggles edit mode
next task is to add keyboard shortcuts for approve/reject and move autofocus in a convenient way, then i will get started on styling, sorting, and filtering
frontend/src/components/PDFLister.tsx Outdated Show resolved Hide resolved
frontend/src/components/PDFLister.tsx Outdated Show resolved Hide resolved
frontend/src/components/PDFLister.tsx Outdated Show resolved Hide resolved
frontend/src/components/PDFTable.tsx Outdated Show resolved Hide resolved
used solid-select library
took me forever to realise that I needed the createOptions thing
looking further is adding dropdown for course_names in such a way to validate input with course_codes
need help with validating input between course_codes and course_names
adding dropdown input to remaining inputs next
fix: remove isEditable mode, will be replaced soon
year dropdown input shows every year since 1951, easy to customise
need to style table more
need to fix the trash approve/reject workflow
need to figure out how to validate the input/output with solid-select
@harshkhandeparkar
Copy link
Member

I think we can skip the modal part. A link to the pdf is more than enough, it'll open in the browser's pdf viewer.

need to style focused element to be more visible, couldn't figure out solid-select styling
removed the coursesSelectMenu component because it was redundant
next would be sorting capability ig because I think I have an idea of how to fix that
@Majestic9169
Copy link
Contributor Author

the modal part would probably be the last step, so yeah, we should have something functional before we get to that. I don't think we need to scrap it completely just yet though, we may be able to do something cool to make the approval process really fast with it

…details

leads to fix: questionpaper year is being updated now
logic looks a little complicated rn, will try to simplify
looking into making table elements searchable
still need to make good approve/reject mechanism
@Majestic9169
Copy link
Contributor Author

I thought captions were useful if the table didn't load or for accessibility reasons

@harshkhandeparkar
Copy link
Member

I thought captions were useful if the table didn't load or for accessibility reasons

Hmm, it looked weird in that place. Maybe we can add it back in the future when we (probably) add more features to the admin dashboard - stats etc.

@harshkhandeparkar
Copy link
Member

If the dashboard has multiple sections it would make more sense. Right now it is just a way to approve uploaded papers.

@proffapt proffapt force-pushed the main branch 2 times, most recently from fdf45e8 to 3e5dbd5 Compare July 2, 2024 11:03
Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's test this in prod

@harshkhandeparkar harshkhandeparkar merged commit 87e5e62 into metakgp:main Aug 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up Admin Dashboard Page
4 participants