Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring & Adding Interfaces #36

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

HeeManSu
Copy link

No description provided.

@viferga viferga marked this pull request as draft July 22, 2024 17:54
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be commited, the version is not 1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition of the interfaces is correct, but the interface API should not be modified, this will imply we have to modify metacall-deploy too, and maybe other dependencies. I do not want to do that yet.

@viferga
Copy link
Member

viferga commented Jul 22, 2024

@HeeManSu I have added few comments, review them and I will merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants