MBS-12170: always give country for artists in relations #3426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening your first pull request for MusicBrainz Server, and welcome to our community! 🎉 |
|
Can one of the admins verify this patch? |
|
This only works if the area is a country, which is not all the time, but it might be a good start. You'd need to also change the relevant tests, at the very least. |
|
@brainzbot, add to whitelist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MBS-12170
Problem
the artist information in a relation doesn't have the artists country in it.
Solution
add the artist country to all responses (not only top level)
Testing
haven't done any testing on this.
i'm a noob and have no idea how to run the api locally.
but the fix seemed pretty obvious.