MBS-13838: Convert class forms to component syntax #3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the <p> surrounding form rows since <div>s shouldn't be inside <p>s and they're not really needed. The only case where it looked worse after the change was for the period change select, where I inserted a line break above to keep the separation.
These don't work on secure forms with style-src CSP headers.
|
This worked well, but there were a lot of fields that didn't need to be controlled, which added a lot of unnecessary code; so I changed those to uncontrolled. I also updated the area field to use |
|
Tested locally, seemed to work fine on all three forms. Not quite sure what is the problem that flow had in the circleci tests, flow passes locally... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-13838
Description
The first forms we converted to React (
ApplicationForm,PreferencesFormandEditProfileForm) use class syntax, which we are trying to get rid of for consistency. This converts them to use component syntax like all the other forms.Testing
Manually.