Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sentry cron monitoring #3090

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Add sentry cron monitoring #3090

wants to merge 12 commits into from

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented Dec 20, 2024

This PR implements cron job monitoring for mbid mapping jobs using sentry's cron support.

All cron related functions have been moved a separate click submenu and now all have a wrapper in cron_wrappers.py that take care of calling sentry and catching errors and reporting the status back to sentry.

This is WIP, after a sanity check careful deployment to gaga with constant monitoring is required.

@mayhem mayhem requested a review from amCap1712 December 20, 2024 12:04
@pep8speaks
Copy link

pep8speaks commented Dec 20, 2024

Hello @mayhem! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 83:1: E303 too many blank lines (3)

Comment last updated at 2025-01-06 13:50:09 UTC

Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants