Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LB-1374: Add sort options for playlists #3081

Merged
merged 2 commits into from
Dec 18, 2024
Merged

LB-1374: Add sort options for playlists #3081

merged 2 commits into from
Dec 18, 2024

Conversation

anshg1214
Copy link
Member

MonkeyDo
MonkeyDo requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working quite well!
Nice work.

The sort option should be reset to default value when navigating to collab playlists and back in setPlaylistType, or alternatively the playlists should be sorted again when you switch back.

@anshg1214 anshg1214 requested a review from MonkeyDo December 18, 2024 08:59
MonkeyDo
MonkeyDo approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@MonkeyDo MonkeyDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lesssgoooo !!!

@MonkeyDo MonkeyDo merged commit 922d46e into master Dec 18, 2024
2 checks passed
@MonkeyDo MonkeyDo deleted the ansh/sort-playlist branch December 18, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonkeyDo MonkeyDo MonkeyDo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshg1214 @MonkeyDo