LB-1689: Improve last.fm loved tracks import #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @amCap1712! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-12-11 06:11:52 UTC |
MonkeyDo
changed the title
mayhem
approved these changes
Dec 10, 2024
The existing importer only tries to import tracks with track_mbids. Extend it to recognise recording_mbids and for tracks without mbids do a messybrainz lookup.
amCap1712
force-pushed
the
lfm-loved-tracks
branch
from
c1c7d42 to
2c3e1b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing importer only tries to import tracks with track_mbids. Extend it to recognise recording_mbids and for tracks without mbids do a messybrainz lookup.