feat: improve apple music fuzzy matching #3011
Conversation
There was a problem hiding this comment.
I haven't done a lot of thorough testing of Apple Music overall, but this seems like an improvement.
However in some cases it appears to be too restrictive and ignoring decent matches.
I went back to this forum comment which has a good example.
The new system does not find an acceptable result to play this track (https://listenbrainz.org/player/?recording_mbids=26a654d4-c528-4d39-90a2-28958d30c828) whereas the existing system does.
I believe this is because by trying to match the album name we might ignore a track with the right name and artist but from a different album (in this case, expecting "Sobredosis de amor y salsa" and ignoring a match from "Greatest Hits" album).
I think the mechanism should prefer the correct album but still play a decent match (right title+artist) in case we don't get the perfect match with matching album name.
|
To test the example above I made this gist to test the fuzzysort results using https://rawgit.com/farzher/fuzzysort/master/test/test.html https://gist.github.com/MonkeyDo/f6d44f54c449ef39957a92dab4a3ba78 |
|
I'm also seeing that the newest version 3.1.0 automatically handles accents and such (we are currently using 3.0.1) so we might be able to drop the use of deburr |
No description provided.