-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Music Player UI for Mobile Devices #2940
base: master
Are you sure you want to change the base?
Conversation
Looks awesome already! Much, much better UI on mobile, and I think the desktop version is also going to be jealous :P
The result is this, with flexbox highlighted for convenience |
c310d7c
to
d860c00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more little pieces of feedback as I've been testing on my phone.
The new player UI is looking sick !
const musicPlayerCoverArtRef = React.useRef<HTMLImageElement>(null); | ||
|
||
React.useEffect(() => { | ||
getAverageRGBOfImage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been looking at how we can improve this color detection stuff, not for right now but more generally.
I found a nice library that will extract multiple prominent colors of an image rather than just the average color:
https://jariz.github.io/vibrant.js/ (deprecated, but see the repo below taking over)
https://github.com/Vibrant-Colors/node-vibrant
That will allow us to use multiple colors from the image for the background and the text and be closer to the look and feel of the image, and preventing "issues" like this one, where the color isn't quite right and the white text is barely legible:
Instead, it would be ideal if we could use the yellow from the image as background and the red color for text and maybe even the green for other elements of the UI.
Something for another day in any case, but could really improve the look
Co-authored-by: Monkey Do <[email protected]>
This reverts commit e2e95d5.
This reverts commit cfea4fd.
Looks like after I finish my queue, the player starts playing from the top despite the loop/repeat option being off EDIT: Sorry I wrote this comment on the wrong PR ! :P |
…erver into add-music-player-ui
…erver into add-music-player-ui
I will let you resolve the conflict if you don't mind, and I'm ready for finalizing the PR (sorry I took so long coming back to this!). |
…erver into add-music-player-ui
I deployed the PR to test.LB
And an extra follow-up issue for another day/another PR: with the mobile device horizontal, we will want to reorganize the layout to suit the aspect ratio better. |
This PR adds a Music Player UI for Mobile Devices