LB-1557: Fix Dashboard URL-encoded username #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ rename component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user reported an issue with space in username.
Since the move to the single-page-app, the secondary nav layout component does not have direct access to a user object, and does not load data itself.
So for showing the user name in the secondary nav, it uses the username from the URL for the current location.
We didn't realize that for users with spaces or special characters in their name, we are showing the URL-encoded version of their name.
We missed a necessary step do decode the URL segment containing the user name.
Also renamed misnamed DashboardLayout component., probably a copy/paste error