BrainzPlayer search fixes #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
encode the colon too, of course!
skip the featuring artists ("feat. XYZ", etc.) that is apparently confusing the spotify search API in some circumstances
It's poor UI to just skip however many songs without letting the user know something is happening. Show a warning when we tried every source with no result as we skip the track.
"track:You've Got the Love artist:Florence + the Machine" returns no results while "You've Got the Love artist:Florence + the Machine" returns results with the expected track first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rob reported a few issues with the spotify player and BP more generally.
After some debugging, we found out why some search queries find no matches despite the song being available in their catalog. Turns out we were not encoding the colons in the search query...
Second issue with spotify search API is due to the featuring artist, which can sometimes cause some issues.
Finally, show a warning toast when we are skipping a track because we found no result, as it is pretty poor UX for the user otherwise for track to be skipped without any explanation, makes it look like a bug.