Skip to content

Commit

Permalink
More dynamic testing. Find a case we don't handle yet (#110)
Browse files Browse the repository at this point in the history
Closes #91 
Closes #73 

This upgrades us to the latest JSQLParser, which fixes one of our fixtures.

Unfortunately it seems there is a bug in the tokens, they are giving off-by-one errors on their line, which was a real pain to discover after going down so many other rabbit holes. They also changed the scope of the Table node to include the alias, which was also quite annoying.

The new Visitor interfaces are really more Foldable / Traversibles, which is great - it means we can use them to make the completeness of our newer walkers statically verified, but I have not done that here yet.
  • Loading branch information
crisptrutski authored Oct 25, 2024
1 parent 0110ed3 commit 19628f5
Show file tree
Hide file tree
Showing 8 changed files with 1,097 additions and 263 deletions.
2 changes: 1 addition & 1 deletion deps.edn
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

:deps
{;; The actual SQL Parser to wrap!
com.github.jsqlparser/jsqlparser {:mvn/version "4.9"}
com.github.jsqlparser/jsqlparser {:mvn/version "5.0"}
;; Get environment variables and Java properties
environ/environ {:mvn/version "1.2.0"}
;; Schema-checking
Expand Down
Loading

0 comments on commit 19628f5

Please sign in to comment.