-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix metaplex metadata already parsed #149
base: main
Are you sure you want to change the base?
Conversation
@@ -155,17 +155,14 @@ async function getMetaplexMetadataForToken( | |||
const decodedMetadata = deserializeMetadata( | |||
tokenMetaDataAccount as unknown as RpcAccount | |||
); | |||
const uriRes = await fetch(decodedMetadata.uri); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And ONLY for the image is why we do it this way..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the uri is actually only the image link, so we were trying to parse the png format as json (what's inside the image url)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the standard and should we change our way to create metadata to align?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The metadata there isn't standard... So it's not following it, yes I'd encourage our adherence to the metadata standard.
No description provided.