(1/2)(torchx/cli) make internal schedulers a workspace scheduler; implement jetter_workspace_scheduler #380
Conversation
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33971673 |
Codecov Report
@@ Coverage Diff @@
## main #380 +/- ##
==========================================
- Coverage 93.96% 93.12% -0.85%
==========================================
Files 64 66 +2
Lines 3565 3535 -30
==========================================
- Hits 3350 3292 -58
- Misses 215 243 +28
Continue to review full report at Codecov.
|
|
This pull request was exported from Phabricator. Differential Revision: D33971673 |
6 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D33971673 |
|
This pull request was exported from Phabricator. Differential Revision: D33971673 |
|
This pull request was exported from Phabricator. Differential Revision: D33971673 |
|
This pull request was exported from Phabricator. Differential Revision: D33971673 |
|
This pull request was exported from Phabricator. Differential Revision: D33971673 |
|
This pull request was exported from Phabricator. Differential Revision: D33971673 |
…lement jetter_workspace_scheduler (#380) Summary: Pull Request resolved: #380 ~~Part 1/2 (need an additional diff to make changes in penv python)~~ (done with this diff) Does the following: 1. Adds a `torchx.workspace.Workspace` MixIn for Schedulers. Move Docker workspace build from docker_scheduler to torchx.workspace.DockerWorkspace 1. Implements a `JetterWorkspace` that uses jetter to build patches. Falls back to torchx custom patch building for BC. 1. Removes the now unnecessary fb/cmd_run (since we moved everything to workspaces. 1. Adds the `JetterWorkspace` mixin to mast, flow, qf, local_fb schedulers 1. Takes out `DockerWorkspace` from docker_scheduler.build_workspace_and_update_role() 1. Adds the `DockerWorkspace` mixin to docker and k8s schedulers 1. Gets rid of `WorkspaceScheduler` (in favor of `Workspace` mixin) and `WorkspaceRunner` (just builds an optional workspace parameter Runner APIs) 1. (bugfix) read from the config_dirs (home + cwd) to get component default args Reviewed By: d4l3k Differential Revision: D33971673 fbshipit-source-id: 3a97553b840c3b60aae651cd1815a667f29e770e
|
This pull request was exported from Phabricator. Differential Revision: D33971673 |
2 participants
Summary:
NOTE: not ready to be officially reviewed yet - publishing early in case someone's curious.
Part 1/2 (need an additional diff to make changes in penv python)
Does the following:
Implements a JetterWorkspaceScheduler that uses jetter to build patches. Falls back to torchx custom patch building for BC.
Removes the now unnecessary fb/cmd_run (since we moved everything to workspaces.
Makes mast and flow schedulers a subclass of JetterWorkspaceScheduler
Differential Revision: D33971673