Skip to content

Remove redundant casts] fbsource/fbcode/torchrec/distributed #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aporialiao wants to merge 1 commit into from
Closed

Remove redundant casts] fbsource/fbcode/torchrec/distributed #3149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions torchrec/distributed/embedding_lookup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import logging
from abc import ABC
from collections import OrderedDict
from typing import Any, cast, Dict, Iterator, List, Optional, Tuple, Union
from typing import Any, Dict, Iterator, List, Optional, Tuple, Union

import torch
import torch.distributed as dist
Expand Down Expand Up @@ -134,8 +134,7 @@ def _load_state_dict(
dst_param.detach().copy_(src_param)
unexpected_keys.remove(key)
else:
# pyre-fixme[22]: The cast is redundant.
missing_keys.append(cast(str, key))
missing_keys.append(key)
return missing_keys, unexpected_keys


Expand Down
Loading