Skip to content

Support get/set the whole row of metaheader+weight+optimizer from backend for checkpoint saving/loading #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobbyliujb wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support get/set the whole row of metaheader+weight+optimizer from backend for checkpoint saving/loading #3148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion torchrec/distributed/embedding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,17 @@ def _initialize_torch_state(self) -> None: # noqa
(
[
# assuming virtual table only supports rw sharding for now
0 if dim == 0 else dim_size
# When backend return whole row, need to respect dim(1)
# otherwise will see shard dim exceeded tensor dim error
(
0
if dim == 0
else (
local_shards[0].metadata.shard_sizes[1]
if dim == 1
else dim_size
)
)
for dim, dim_size in enumerate(
self._name_to_table_size[table_name]
)
Expand Down
Loading