OSS TorchRec MPZCH Modules (#3089) #3147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77558442 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77558442 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jun 30, 2025
Summary: Pull Request resolved: meta-pytorch#3147 Pull Request resolved: meta-pytorch#3089 Pull Request resolved: meta-pytorch#3017 ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Update `BUCK` files in related folders - Update the affected repos to use `torchrec` modules instead of the modules in `torchrec.fb` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module - Update the license declaration headers for the four OSS files - Add Non-GPU skip condition check for the test `test_dynamically_switch_inference_training_mode` in `torchrec/modules/tests/test_hash_mc_modules.py`. - Rewrite downstream codes' dependencies to MPZCH modules with the open sourced one (from `"//torchrec/fb/modules:hash_mc_*"` to `"//torchrec/modules:hash_mc_*"`, and from `torch.fb.modules.hash_mc_*` to `torch.modules.hash_mc_*`, except for files in the following paths: `dper_lib,torchrec/fb,minimal_viable_ai,~` to avoid breaking mvai cogwheel tests. ### ToDos after landing this Diff - Clean the duplicated `hash_mc_*.py` file in the `fb` folder for safe landing. Differential Revision: D77558442
lizhouyu
force-pushed
the
export-D77558442
branch
from
a96ace7 to
7d45d56
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77558442 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jun 30, 2025
Summary: Pull Request resolved: meta-pytorch#3147 Pull Request resolved: meta-pytorch#3089 Pull Request resolved: meta-pytorch#3017 ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Update `BUCK` files in related folders - Update the affected repos to use `torchrec` modules instead of the modules in `torchrec.fb` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module - Update the license declaration headers for the four OSS files - Add Non-GPU skip condition check for the test `test_dynamically_switch_inference_training_mode` in `torchrec/modules/tests/test_hash_mc_modules.py`. - Rewrite downstream codes' dependencies to MPZCH modules with the open sourced one (from `"//torchrec/fb/modules:hash_mc_*"` to `"//torchrec/modules:hash_mc_*"`, and from `torch.fb.modules.hash_mc_*` to `torch.modules.hash_mc_*`, except for files in the following paths: `dper_lib,torchrec/fb,minimal_viable_ai,~` to avoid breaking mvai cogwheel tests. ### ToDos after landing this Diff - Clean the duplicated `hash_mc_*.py` file in the `fb` folder for safe landing. Differential Revision: D77558442
lizhouyu
force-pushed
the
export-D77558442
branch
from
7d45d56 to
7a2ab18
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77558442 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 1, 2025
Summary: Pull Request resolved: meta-pytorch#3147 Pull Request resolved: meta-pytorch#3089 Pull Request resolved: meta-pytorch#3017 ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Update `BUCK` files in related folders - Update the affected repos to use `torchrec` modules instead of the modules in `torchrec.fb` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module - Update the license declaration headers for the four OSS files - Add Non-GPU skip condition check for the test `test_dynamically_switch_inference_training_mode` in `torchrec/modules/tests/test_hash_mc_modules.py`. - Rewrite downstream codes' dependencies to MPZCH modules with the open sourced one (from `"//torchrec/fb/modules:hash_mc_*"` to `"//torchrec/modules:hash_mc_*"`, and from `torch.fb.modules.hash_mc_*` to `torch.modules.hash_mc_*`, except for files in the following paths: `dper_lib,torchrec/fb,minimal_viable_ai,~` to avoid breaking mvai cogwheel tests. ### ToDos after landing this Diff - Clean the duplicated `hash_mc_*.py` file in the `fb` folder for safe landing. Differential Revision: D77558442
lizhouyu
force-pushed
the
export-D77558442
branch
from
7a2ab18 to
9d13e6e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77558442 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 1, 2025
Summary: Pull Request resolved: meta-pytorch#3147 Pull Request resolved: meta-pytorch#3089 Pull Request resolved: meta-pytorch#3017 ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Update `BUCK` files in related folders - Update the affected repos to use `torchrec` modules instead of the modules in `torchrec.fb` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module - Update the license declaration headers for the four OSS files - Add Non-GPU skip condition check for the test `test_dynamically_switch_inference_training_mode` in `torchrec/modules/tests/test_hash_mc_modules.py`. - Rewrite downstream codes' dependencies to MPZCH modules with the open sourced one (from `"//torchrec/fb/modules:hash_mc_*"` to `"//torchrec/modules:hash_mc_*"`, and from `torch.fb.modules.hash_mc_*` to `torch.modules.hash_mc_*`, except for files in the following paths: `dper_lib,torchrec/fb,minimal_viable_ai,~` to avoid breaking mvai cogwheel tests. ### ToDos after landing this Diff - Clean the duplicated `hash_mc_*.py` file in the `fb` folder for safe landing. Differential Revision: D77558442
lizhouyu
force-pushed
the
export-D77558442
branch
from
9d13e6e to
137821c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77558442 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 1, 2025
Summary: Pull Request resolved: meta-pytorch#3147 Pull Request resolved: meta-pytorch#3089 Pull Request resolved: meta-pytorch#3017 ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Update `BUCK` files in related folders - Update the affected repos to use `torchrec` modules instead of the modules in `torchrec.fb` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module to avoid OSS CI test failures - The original tensorboard version is kept in the `torchrec/fb` folder. - Update the license declaration headers for the four OSS files - Add Non-GPU skip condition check for the test `test_dynamically_switch_inference_training_mode` in `torchrec/modules/tests/test_hash_mc_modules.py`. - Rewrite downstream codes' dependencies to MPZCH modules with the open sourced one (from `"//torchrec/fb/modules:hash_mc_*"` to `"//torchrec/modules:hash_mc_*"`, and from `torch.fb.modules.hash_mc_*` to `torch.modules.hash_mc_*`, except for files in the following paths: `dper_lib,torchrec/fb,minimal_viable_ai,~` to avoid breaking mvai cogwheel tests. ### ToDos after landing this Diff - Clean the duplicated `hash_mc_*.py` file in the `fb` folder for safe landing. Differential Revision: D77558442
lizhouyu
force-pushed
the
export-D77558442
branch
from
137821c to
e4c47bb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77558442 |
lizhouyu
force-pushed
the
export-D77558442
branch
from
e4c47bb to
a8758ce
Compare
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 1, 2025
Summary: Pull Request resolved: meta-pytorch#3147 Pull Request resolved: meta-pytorch#3089 Pull Request resolved: meta-pytorch#3017 ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Update `BUCK` files in related folders - Update the affected repos to use `torchrec` modules instead of the modules in `torchrec.fb` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module to avoid OSS CI test failures - The original tensorboard version is kept in the `torchrec/fb` folder. - Update the license declaration headers for the four OSS files - Add Non-GPU skip condition check for the test `test_dynamically_switch_inference_training_mode` in `torchrec/modules/tests/test_hash_mc_modules.py`. - Rewrite downstream codes' dependencies to MPZCH modules with the open sourced one (from `"//torchrec/fb/modules:hash_mc_*"` to `"//torchrec/modules:hash_mc_*"`, and from `torch.fb.modules.hash_mc_*` to `torch.modules.hash_mc_*`, except for files in the following paths: `dper_lib,torchrec/fb,minimal_viable_ai,~` to avoid breaking mvai cogwheel tests. ### ToDos after landing this Diff - Clean the duplicated `hash_mc_*.py` file in the `fb` folder for safe landing. Differential Revision: D77558442
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77558442 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 1, 2025
Summary: Pull Request resolved: meta-pytorch#3147 Pull Request resolved: meta-pytorch#3089 Pull Request resolved: meta-pytorch#3017 ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Update `BUCK` files in related folders - Update the affected repos to use `torchrec` modules instead of the modules in `torchrec.fb` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module to avoid OSS CI test failures - The original tensorboard version is kept in the `torchrec/fb` folder. - Update the license declaration headers for the four OSS files - Add Non-GPU skip condition check for the test `test_dynamically_switch_inference_training_mode` in `torchrec/modules/tests/test_hash_mc_modules.py`. - Rewrite downstream codes' dependencies to MPZCH modules with the open sourced one (from `"//torchrec/fb/modules:hash_mc_*"` to `"//torchrec/modules:hash_mc_*"`, and from `torch.fb.modules.hash_mc_*` to `torch.modules.hash_mc_*`, except for files in the following paths: `dper_lib,torchrec/fb,minimal_viable_ai,~` to avoid breaking mvai cogwheel tests. ### ToDos after landing this Diff - Clean the duplicated `hash_mc_*.py` file in the `fb` folder for safe landing. Differential Revision: D77558442
lizhouyu
force-pushed
the
export-D77558442
branch
from
a8758ce to
98a0c9d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77558442 |
lizhouyu
force-pushed
the
export-D77558442
branch
from
98a0c9d to
9ea2d09
Compare
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 1, 2025
Summary: Pull Request resolved: meta-pytorch#3147 Pull Request resolved: meta-pytorch#3089 Pull Request resolved: meta-pytorch#3017 ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module to avoid OSS CI test failures - The original tensorboard version is kept in the `torchrec/fb` folder. - Update the license declaration headers for the four OSS files Differential Revision: D77558442
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77558442 |
lizhouyu
added a commit
to lizhouyu/torchrec
that referenced
this pull request
Jul 1, 2025
Summary: Pull Request resolved: meta-pytorch#3147 Pull Request resolved: meta-pytorch#3089 Pull Request resolved: meta-pytorch#3017 ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module to avoid OSS CI test failures - The original tensorboard version is kept in the `torchrec/fb` folder. - Update the license declaration headers for the four OSS files Differential Revision: D77558442
lizhouyu
force-pushed
the
export-D77558442
branch
from
9ea2d09 to
0770298
Compare
Summary: ### Major changes - Copy the following files from `fb` to corresponding location in the `torchrec` repository - `fb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.py` - `fb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.py` - `fb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.py` - `fb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.py` - `fb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.py` - `fb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.py` - Update `/modules/hash_mc_metrics.py` - Replace the tensorboard module with a local file logger in `hash_mc_metrics.py` module to avoid OSS CI test failures - The original tensorboard version is kept in the `torchrec/fb` folder. - Update the license declaration headers for the four OSS files Reviewed By: kausv Differential Revision: D77558442
lizhouyu
force-pushed
the
export-D77558442
branch
from
0770298 to
f3afaa8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D77558442 |
Contributor
|
This pull request has been reverted by 8b9c461. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Major changes
fbto corresponding location in thetorchrecrepositoryfb/distributed/hash_mc_embedding.py → torchrec/distributed/hash_mc_embedding.pyfb/modules/hash_mc_evictions.py → torchrec/modules/hash_mc_evictions.pyfb/modules/hash_mc_metrics.py → torchrec/modules/hash_mc_metrics.pyfb/modules/hash_mc_modules.py → torchrec/modules/hash_mc_modules.pyfb/modules/tests/test_hash_mc_evictions.py → torchrec/modules/tests/test_hash_mc_evictions.pyfb/modules/tests/test_hash_mc_modules.py → torchrec/modules/tests/test_hash_mc_modules.pyBUCKfiles in related folderstorchrecmodules instead of the modules intorchrec.fb/modules/hash_mc_metrics.pyhash_mc_metrics.pymoduletest_dynamically_switch_inference_training_modeintorchrec/modules/tests/test_hash_mc_modules.py."//torchrec/fb/modules:hash_mc_*"to"//torchrec/modules:hash_mc_*", and fromtorch.fb.modules.hash_mc_*totorch.modules.hash_mc_*, except for files in the following paths:dper_lib,torchrec/fb,minimal_viable_ai,~to avoid breaking mvai cogwheel tests.ToDos after landing this Diff
hash_mc_*.pyfile in thefbfolder for safe landing.Differential Revision: D77558442