Open
Conversation
Contributor
Summary: Reland of pytorch/pytorch#172796. Which replaced pytorch/pytorch#151845 due to infra issue with pytorchbot PAT and ROCm fork where PR branch was originally hosted. Which was a reland of pytorch/pytorch#137157. - "MasqueradingAsCUDA" files and classes thinly wrap their corresponding CUDA classes. - Do not rename "CUDA" classes to "HIP". cc sunway513 jithunnair-amd pruthvistony ROCmSupport jataylo hongxiayang naromero77amd pragupta jerrymannil xinyazhang voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben X-link: pytorch/pytorch#174087 Reviewed By: malfet Differential Revision: D92063294 Pulled By: atalman
8ffeef5 to
7ba24ed
Compare
atalman
pushed a commit
to atalman/MSLK
that referenced
this pull request
Feb 3, 2026
Summary: X-link: meta-pytorch/torchcomms#544 Reland of pytorch/pytorch#172796. Which replaced pytorch/pytorch#151845 due to infra issue with pytorchbot PAT and ROCm fork where PR branch was originally hosted. Which was a reland of pytorch/pytorch#137157. - "MasqueradingAsCUDA" files and classes thinly wrap their corresponding CUDA classes. - Do not rename "CUDA" classes to "HIP". cc sunway513 jithunnair-amd pruthvistony ROCmSupport jataylo hongxiayang naromero77amd pragupta jerrymannil xinyazhang voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben X-link: pytorch/pytorch#174087 Reviewed By: malfet Differential Revision: D92063294 Pulled By: atalman
jeffdaily
approved these changes
Feb 3, 2026
sudharssun
approved these changes
Feb 3, 2026
sudharssun
added a commit
to sudharssun/torchcomms-1
that referenced
this pull request
Feb 6, 2026
Summary: This was backed out (D91603922) when the original Pytorch caffe2 Hipify removal diff was backed out. Turns out we need a little more changes than the diff above in order to correctly run the unit tests. Now that the caffe2 diff is in again (meta-pytorch#544), we need to check this in again. Reviewed By: atalman Differential Revision: D92454446
Closed
sudharssun
added a commit
to sudharssun/torchcomms-1
that referenced
this pull request
Feb 6, 2026
Summary: This was backed out (D91603922) when the original Pytorch caffe2 Hipify removal diff was backed out. Turns out we need a little more changes than the diff above in order to correctly run the unit tests. Now that the caffe2 diff is in again (meta-pytorch#544), we need to check this in again. Reviewed By: atalman Differential Revision: D92454446
sudharssun
added a commit
to sudharssun/torchcomms-1
that referenced
this pull request
Feb 6, 2026
Summary: This was backed out (D91603922) when the original Pytorch caffe2 Hipify removal diff was backed out. Turns out we need a little more changes than the diff above in order to correctly run the unit tests. Now that the caffe2 diff is in again (meta-pytorch#544), we need to check this in again. Reviewed By: atalman Differential Revision: D92454446
meta-codesync bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
Summary: Pull Request resolved: #575 This was backed out (D91603922) when the original Pytorch caffe2 Hipify removal diff was backed out. Turns out we need a little more changes than the diff above in order to correctly run the unit tests. Now that the caffe2 diff is in again (#544), we need to check this in again. Reviewed By: atalman Differential Revision: D92454446 fbshipit-source-id: a794862662f06519c80108182ff00a599e6e2692
Chao1Han
pushed a commit
to Chao1Han/torchcomms
that referenced
this pull request
Feb 27, 2026
Summary: Pull Request resolved: meta-pytorch#575 This was backed out (D91603922) when the original Pytorch caffe2 Hipify removal diff was backed out. Turns out we need a little more changes than the diff above in order to correctly run the unit tests. Now that the caffe2 diff is in again (meta-pytorch#544), we need to check this in again. Reviewed By: atalman Differential Revision: D92454446 fbshipit-source-id: a794862662f06519c80108182ff00a599e6e2692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: meta-pytorch/MSLK#131
Reland of pytorch/pytorch#172796. Which replaced pytorch/pytorch#151845 due to infra issue with pytorchbot PAT and ROCm fork where PR branch was originally hosted. Which was a reland of pytorch/pytorch#137157.
cc sunway513 jithunnair-amd pruthvistony ROCmSupport jataylo hongxiayang naromero77amd pragupta jerrymannil xinyazhang voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben
X-link: pytorch/pytorch#174087
Reviewed By: malfet
Differential Revision: D92063294
Pulled By: atalman