Skip to content

remove caffe2 from hipify#544

Open
atalman wants to merge 1 commit intometa-pytorch:mainfrom
atalman:export-D92063294
Open

remove caffe2 from hipify#544
atalman wants to merge 1 commit intometa-pytorch:mainfrom
atalman:export-D92063294

Conversation

@atalman
Copy link
Copy Markdown

@atalman atalman commented Feb 3, 2026

Summary:
X-link: meta-pytorch/MSLK#131

Reland of pytorch/pytorch#172796. Which replaced pytorch/pytorch#151845 due to infra issue with pytorchbot PAT and ROCm fork where PR branch was originally hosted. Which was a reland of pytorch/pytorch#137157.

  • "MasqueradingAsCUDA" files and classes thinly wrap their corresponding CUDA classes.
  • Do not rename "CUDA" classes to "HIP".

cc sunway513 jithunnair-amd pruthvistony ROCmSupport jataylo hongxiayang naromero77amd pragupta jerrymannil xinyazhang voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben

X-link: pytorch/pytorch#174087

Reviewed By: malfet

Differential Revision: D92063294

Pulled By: atalman

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 3, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync bot commented Feb 3, 2026

@atalman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D92063294.

Summary:
Reland of pytorch/pytorch#172796.  Which replaced pytorch/pytorch#151845 due to infra issue with pytorchbot PAT and ROCm fork where PR branch was originally hosted.  Which was a reland of pytorch/pytorch#137157.

- "MasqueradingAsCUDA" files and classes thinly wrap their corresponding CUDA classes.
- Do not rename "CUDA" classes to "HIP".

cc sunway513 jithunnair-amd pruthvistony ROCmSupport jataylo hongxiayang naromero77amd pragupta jerrymannil xinyazhang voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben

X-link: pytorch/pytorch#174087

Reviewed By: malfet

Differential Revision: D92063294

Pulled By: atalman
atalman pushed a commit to atalman/MSLK that referenced this pull request Feb 3, 2026
Summary:
X-link: meta-pytorch/torchcomms#544

Reland of pytorch/pytorch#172796.  Which replaced pytorch/pytorch#151845 due to infra issue with pytorchbot PAT and ROCm fork where PR branch was originally hosted.  Which was a reland of pytorch/pytorch#137157.

- "MasqueradingAsCUDA" files and classes thinly wrap their corresponding CUDA classes.
- Do not rename "CUDA" classes to "HIP".

cc sunway513 jithunnair-amd pruthvistony ROCmSupport jataylo hongxiayang naromero77amd pragupta jerrymannil xinyazhang voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben

X-link: pytorch/pytorch#174087

Reviewed By: malfet

Differential Revision: D92063294

Pulled By: atalman
@meta-pytorch meta-pytorch deleted a comment from pytorch-bot bot Feb 3, 2026
sudharssun added a commit to sudharssun/torchcomms-1 that referenced this pull request Feb 6, 2026
Summary:
This was backed out (D91603922) when the original Pytorch caffe2 Hipify removal diff was backed out.

Turns out we need a little more changes than the diff above in order to correctly run the unit tests.

Now that the caffe2 diff is in again (meta-pytorch#544), we need to check this in again.

Reviewed By: atalman

Differential Revision: D92454446
@sudharssun sudharssun mentioned this pull request Feb 6, 2026
sudharssun added a commit to sudharssun/torchcomms-1 that referenced this pull request Feb 6, 2026
Summary:

This was backed out (D91603922) when the original Pytorch caffe2 Hipify removal diff was backed out.

Turns out we need a little more changes than the diff above in order to correctly run the unit tests.

Now that the caffe2 diff is in again (meta-pytorch#544), we need to check this in again.

Reviewed By: atalman

Differential Revision: D92454446
sudharssun added a commit to sudharssun/torchcomms-1 that referenced this pull request Feb 6, 2026
Summary:

This was backed out (D91603922) when the original Pytorch caffe2 Hipify removal diff was backed out.

Turns out we need a little more changes than the diff above in order to correctly run the unit tests.

Now that the caffe2 diff is in again (meta-pytorch#544), we need to check this in again.

Reviewed By: atalman

Differential Revision: D92454446
meta-codesync bot pushed a commit that referenced this pull request Feb 6, 2026
Summary:
Pull Request resolved: #575

This was backed out (D91603922) when the original Pytorch caffe2 Hipify removal diff was backed out.

Turns out we need a little more changes than the diff above in order to correctly run the unit tests.

Now that the caffe2 diff is in again (#544), we need to check this in again.

Reviewed By: atalman

Differential Revision: D92454446

fbshipit-source-id: a794862662f06519c80108182ff00a599e6e2692
Chao1Han pushed a commit to Chao1Han/torchcomms that referenced this pull request Feb 27, 2026
Summary:
Pull Request resolved: meta-pytorch#575

This was backed out (D91603922) when the original Pytorch caffe2 Hipify removal diff was backed out.

Turns out we need a little more changes than the diff above in order to correctly run the unit tests.

Now that the caffe2 diff is in again (meta-pytorch#544), we need to check this in again.

Reviewed By: atalman

Differential Revision: D92454446

fbshipit-source-id: a794862662f06519c80108182ff00a599e6e2692
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants