Skip to content

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Oct 17, 2025

Summary: Add functionality to hf_tokenizer to parse special_tokens_map.json, which contains the source of truth for which bos/eos to use.

Reviewed By: larryliu0820

Differential Revision: D84878533

Summary: Add functionality to hf_tokenizer to parse special_tokens_map.json, which contains the source of truth for which bos/eos to use.

Reviewed By: larryliu0820

Differential Revision: D84878533
@meta-codesync
Copy link

meta-codesync bot commented Oct 17, 2025

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D84878533.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 17, 2025
Copy link
Contributor

@larryliu0820 larryliu0820 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@meta-codesync meta-codesync bot merged commit 572e407 into meta-pytorch:main Oct 18, 2025
7 of 8 checks passed
lucylq added a commit to lucylq/executorch-1 that referenced this pull request Oct 18, 2025
Summary: Pull in meta-pytorch/tokenizers#146

Differential Revision: D84991625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants