[hydra-configs-torch] torch1.6 data configs #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
romesco
changed the title
|
One other change in this PR: I've moved the configen source confs to include separate folders per project. -> It might be better if these were just |
This was
linked to
issues
Dec 22, 2020
omry
reviewed
Dec 22, 2020
| data.IterableDataset(), | ||
| id="IterableDatasetConf", | ||
| ), | ||
| # TODO: investigate asterisk in signature instantiation limitation |
There was a problem hiding this comment.
Can you file an issue on the repo so we don't lost track?
There was a problem hiding this comment.
You saw the rest of the issues, but here:
facebookresearch/hydra#1243
Will get the minimal repro for this one. The others, once we nail them down, we can get minimal repros for those as well.
There was a problem hiding this comment.
There is a chance that this will one will be difficult to solve. Let's assume we need a workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds configs for
Datasetvariants andSamplervariants.Adds tests for all configs except:
TensorDatasetConfandDistributedSamplerConf.The former has a funny issue with instantiation due to the asterisk in it's signature which I'm investigating. The latter requires setting up a distributed env to test instantiation. Not sure about the cleanest way to automate this test yet.
Addresses: #1, #45