Fix batch computation in Pivoted Cholesky #2823
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72906531 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72906531 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2823 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 211 211
Lines 19286 19286
=========================================
Hits 19286 19286 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ltiao
added a commit
to ltiao/botorch
that referenced
this pull request
Apr 25, 2025
Summary: ## Context Resolves issue meta-pytorch#2819 where `PivotedCholesky.update_` break when there is more than a single batch dimension. ## Changes Updates a line to extend boolean indexing logic to cases where `len(batch_shape) > 1` Reviewed By: saitcakmak Differential Revision: D72906531
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72906531 |
ltiao
added a commit
to ltiao/botorch
that referenced
this pull request
Apr 25, 2025
Summary: ## Context Resolves issue meta-pytorch#2819 where `PivotedCholesky.update_` break when there is more than a single batch dimension. ## Changes Updates a line to extend boolean indexing logic to cases where `len(batch_shape) > 1` Reviewed By: saitcakmak Differential Revision: D72906531
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72906531 |
ltiao
added a commit
to ltiao/botorch
that referenced
this pull request
Apr 25, 2025
Summary: ## Context Resolves issue meta-pytorch#2819 where `PivotedCholesky.update_` break when there is more than a single batch dimension. ## Changes Updates a line to extend boolean indexing logic to cases where `len(batch_shape) > 1` Reviewed By: saitcakmak Differential Revision: D72906531
Summary: Pull Request resolved: meta-pytorch#2823 ## Context Resolves issue meta-pytorch#2819 where `PivotedCholesky.update_` break when there is more than a single batch dimension. ## Changes Updates a line to extend boolean indexing logic to cases where `len(batch_shape) > 1` Reviewed By: saitcakmak Differential Revision: D72906531
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72906531 |
Contributor
|
This pull request has been merged in cbada4c. |
1 task
Contributor
Author
|
Closes #2819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Summary
TODO:
Changes
Updates a line containing indexing logic that breaks when
len(batch_shape) > 1Differential Revision: D72906531