[asynctp] Optimize agmm lastdim via addmm_ #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
IvanKobzarev
force-pushed
the
IvanKobzarev/stack/7
branch
from
89626c4 to
0ce9c0c
Compare
Open
stack-info: PR: #190, branch: IvanKobzarev/stack/7
IvanKobzarev
force-pushed
the
IvanKobzarev/stack/7
branch
from
0ce9c0c to
357dd7e
Compare
fmassa
approved these changes
Oct 8, 2025
Contributor
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
I don't have all the context on this file yet, but changes LGTM in general.
| outputs[idx] += output_partials[idx] | ||
| out = outputs[idx] | ||
| if first: | ||
| torch.ops.aten.mm.out(shard, B_shards[idx][rank], **kwargs, out=out) |
Contributor
There was a problem hiding this comment.
Should we prefer using the torch.mm version instead of the torch.ops.aten.mm version? I'm not sure there is effectively a difference, but maybe for consistency?
Contributor
Author
There was a problem hiding this comment.
Yeah, I think there should not be much difference, we can use torch.mm.
Contributor
Author
Oh, yeah, I want to add e2e test but on torchtitan/autoparallel with asynctp/bucketing/overlap configs once configs are landed pytorch/torchtitan#1838 |
|
Yea - thought this was in pytorch repro at first / more stand alone.. less easy here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
[asynctp] Optimize agmm lastdim via addmm_