Parametrized build-type per config #128
Merged
+120
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
kerberjg
force-pushed
the
feature/fs-build_config_switch
branch
from
9b8d03e to
6fa81b0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
kerberjg
force-pushed
the
feature/fs-build_config_switch
branch
from
6fa81b0 to
b04ca8b
Compare
kerberjg
changed the title
kerberjg
force-pushed
the
feature/fs-build_config_switch
branch
8 times, most recently
from
38e3e26 to
8bd63f0
Compare
kerberjg
force-pushed
the
feature/fs-build_config_switch
branch
2 times, most recently
from
83cc4a5 to
068875a
Compare
See configs/globals.json
- supports debug/profile/release - switch via `--build-type <platform-id>:<build_type>,...` - translates to CMAKE_BUILD_TYPE and MESON_BUILD_TYPE - defaults to value in `configs/globals.json`
kerberjg
force-pushed
the
feature/fs-build_config_switch
branch
from
bcaa041 to
479f833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for easier switching between Release/Profile/Debug via
--build-type <platform_id>:<build_type>,...If not specified, defaults to the value in
globals.json(release) ✨Allowed values are:
releaseprofiledebugThis is later translated to
CMAKE_BUILD_TYPEandMESON_BUILD_TYPE, set when initializing the environment for each config.Raw value is passed as
_BUILD_TYPEand used to name paths wherever applicable.Switches from
MinSizeReltoRelease- the former applies optimizations that are known to be detrimental to performance, especially on mobile (in exchange for minor size gains)Bonus changes! 💚
configs/filament-debug-v1.65.2.jsonin favor of--build-type filament:debugCMAKE_EXPORT_COMPILE_COMMANDSinfilament_viewplugin