build: Specify go1.22.2 as toolchain to fix govulncheck issues #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
changed the title
Nix (and therefore devbox) has been slow in rolling out go1.22.2, which contains CVE fixes. Current version go1.22.1 causes govulncheck to report valid vulnerabilities in `net/http` package. go1.21 introduced toolchain management via `go.mod` file with `toolchain` directive. This commit specifies go1.22.2 as the toolchain to use and hence fixes the govulncheck issues. This does mean that go versions have to be managed in multiple places so this is a stop-gap until Nix releases go1.22.2 to nixpkgs-unstable channel.
jimmidyson
force-pushed
the
jimmi/go-1.22.2-toolchain
branch
from
7739b28
to
98a61f9
Compare
mhrabovcin
approved these changes
Apr 17, 2024
Merged
jimmidyson
pushed a commit
that referenced
this pull request
Apr 17, 2024
🤖 I have created a release *beep* *boop* --- ## 1.13.3 (2024-04-17) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Other Changes * ci: New org for devbox-install-action - missed in previous PR by @jimmidyson in #686 * build: Specify go1.22.2 as toolchain to fix govulncheck issues by @jimmidyson in #688 **Full Changelog**: v1.13.2...v1.13.3 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: mesosphere-actions-pr-bot[bot] <157582460+mesosphere-actions-pr-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nix (and therefore devbox) has been slow in rolling out go1.22.2, which
contains CVE fixes. Current version go1.22.1 causes govulncheck to
report valid vulnerabilities in
net/httppackage. go1.21 introducedtoolchain management via
go.modfile withtoolchaindirective. Thiscommit specifies go1.22.2 as the toolchain to use and hence fixes the
govulncheck issues.
This does mean that go versions have to be managed in multiple places so
this is a stop-gap until Nix releases go1.22.2 to nixpkgs-unstable
channel.