Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sqlitecpp 3.3.1-1 #1131

Merged
merged 1 commit into from
Sep 21, 2023
Merged

add sqlitecpp 3.3.1-1 #1131

merged 1 commit into from
Sep 21, 2023

Conversation

UnixY2K
Copy link
Contributor

@UnixY2K UnixY2K commented Aug 28, 2023

adds SQLiteCpp version 3.3.1 to the list of wraps

If there is anything else required just let me know

a previous PR for this wrap was in #816

@UnixY2K
Copy link
Contributor Author

UnixY2K commented Aug 28, 2023

seems that the CI is not passing due to some errors regarding gtest

@neheb
Copy link
Collaborator

neheb commented Aug 28, 2023

error: ‘std::enable_if_t’ has not been declared
  302 |   template <typename T, std::enable_if_t<std::is_convertible<T, int64_t>::value,

Needs C++14.

@neheb
Copy link
Collaborator

neheb commented Aug 28, 2023

Add sqlitecpp:std_cpp=c++14 I guess.

@jpakkane
Copy link
Member

You need to set the C++ std version to something newer. Some platforms seem to default to c++11 or even older.

@neheb
Copy link
Collaborator

neheb commented Aug 28, 2023

Yeah all projects using gtest 1.14 need to be using C++14: https://github.com/google/googletest/releases/tag/v1.14.0

@UnixY2K
Copy link
Contributor Author

UnixY2K commented Aug 28, 2023

yes, I noticed that also, the project uses by default c++11 and gtest 1.12.1 so I will send a PR to the main project in the meantime

@jpakkane
Copy link
Member

Their readme specifically mentions depending only on c++11, so that might be a hard sell.

@neheb
Copy link
Collaborator

neheb commented Aug 28, 2023

Readme seems outdated. I'd just mention that C++11 has been deprecated by at least MSVC.

@UnixY2K
Copy link
Contributor Author

UnixY2K commented Aug 28, 2023

Their readme specifically mentions depending only on c++11, so that might be a hard sell.

I guess some users can just use an older GTest if required, specially the ones using older compilers in ubuntu or debian

Readme seems outdated. I'd just mention that C++11 has been deprecated by at least MSVC.

Yes, in fact for windows C++14 is already the default.

I made a PR on the main repo: SRombauts/SQLiteCpp#448

@neheb
Copy link
Collaborator

neheb commented Sep 17, 2023

for now, you can add the fixed meson.build file to packagefiles such that it gets overwritten.

@UnixY2K
Copy link
Contributor Author

UnixY2K commented Sep 20, 2023

forgot to add the patch directory, the build is passing for all except macos, as is using included sqlite

@UnixY2K
Copy link
Contributor Author

UnixY2K commented Sep 20, 2023

the CI is failing on MacOS due to the included SQLite3, is there a way to force the fallback?
the SQLitecpp repo uses --force-fallback-for=sqlite3

@neheb
Copy link
Collaborator

neheb commented Sep 20, 2023

For macOS you can probably install SQLite with brew and use it. ci_config has examples with ffmpeg for example.

subprojects/sqlitecpp.wrap Outdated Show resolved Hide resolved
@UnixY2K
Copy link
Contributor Author

UnixY2K commented Sep 21, 2023

for macos still failing even after brew install

edit found this

sqlite is keg-only, which means it was not symlinked into /usr/local,
because macOS already provides this software and installing another version in
parallel can cause all kinds of trouble.

If you need to have sqlite first in your PATH, run:
  echo 'export PATH="/usr/local/opt/sqlite/bin:$PATH"' >> /Users/runner/.bash_profile

For compilers to find sqlite you may need to set:
  export LDFLAGS="-L/usr/local/opt/sqlite/lib"
  export CPPFLAGS="-I/usr/local/opt/sqlite/include"

For pkg-config to find sqlite you may need to set:
  export PKG_CONFIG_PATH="/usr/local/opt/sqlite/lib/pkgconfig"

@neheb
Copy link
Collaborator

neheb commented Sep 21, 2023

yes I told you how to fix it. You need to add pkgconfig paths. this is done with libffmpegthumbnailer for example.

@neheb neheb merged commit f7b09e0 into mesonbuild:master Sep 21, 2023
@UnixY2K UnixY2K deleted the sqlitecpp-3.3.1-1 branch January 28, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants