-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sqlitecpp 3.3.1-1 #1131
add sqlitecpp 3.3.1-1 #1131
Conversation
seems that the CI is not passing due to some errors regarding gtest |
Needs C++14. |
Add sqlitecpp:std_cpp=c++14 I guess. |
You need to set the C++ std version to something newer. Some platforms seem to default to c++11 or even older. |
Yeah all projects using gtest 1.14 need to be using C++14: https://github.com/google/googletest/releases/tag/v1.14.0 |
yes, I noticed that also, the project uses by default c++11 and gtest 1.12.1 so I will send a PR to the main project in the meantime |
Their readme specifically mentions depending only on c++11, so that might be a hard sell. |
Readme seems outdated. I'd just mention that C++11 has been deprecated by at least MSVC. |
I guess some users can just use an older GTest if required, specially the ones using older compilers in ubuntu or debian
Yes, in fact for windows C++14 is already the default. I made a PR on the main repo: SRombauts/SQLiteCpp#448 |
for now, you can add the fixed meson.build file to packagefiles such that it gets overwritten. |
forgot to add the patch directory, the build is passing for all except macos, as is using included sqlite |
the CI is failing on MacOS due to the included SQLite3, is there a way to force the fallback? |
For macOS you can probably install SQLite with brew and use it. ci_config has examples with ffmpeg for example. |
for macos still failing even after brew install edit found this
|
yes I told you how to fix it. You need to add pkgconfig paths. this is done with libffmpegthumbnailer for example. |
adds SQLiteCpp version 3.3.1 to the list of wraps
If there is anything else required just let me know