Clean up gnome mkenums, and use typed_kwargs#9700
Merged
eli-schwartz merged 5 commits intomesonbuild:masterfrom Dec 20, 2021
Merged
Clean up gnome mkenums, and use typed_kwargs#9700eli-schwartz merged 5 commits intomesonbuild:masterfrom
eli-schwartz merged 5 commits intomesonbuild:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9700 +/- ##
==========================================
- Coverage 67.12% 64.00% -3.12%
==========================================
Files 404 202 -202
Lines 85845 42770 -43075
Branches 18955 9337 -9618
==========================================
- Hits 57621 27377 -30244
+ Misses 23680 13182 -10498
+ Partials 4544 2211 -2333
Continue to review full report at Codecov.
|
dcbaker
force-pushed
the
submit/gnome-mkenums-type-kwargs
branch
from
59233d4 to
e5b86f5
Compare
dcbaker
force-pushed
the
submit/gnome-mkenums-type-kwargs
branch
2 times, most recently
from
b3d288c to
9b8fc55
Compare
Member
Author
|
Anyone planning to look at this, or should I just merge it? |
This has never been in permittedKwargs, it does nothing, and it was never documented, so it seems pretty safe to just remove it.
the simple_version still goes through the big version of this function, but at last we have type checking
It's just a bad idea, but especially once we start adding type annotations to both of them.
This is the last function that doesn't use typed_kwargs. This now uses the same shared path as the mkenums_simple
because List is invariant, and that's not what we want.
dcbaker
force-pushed
the
submit/gnome-mkenums-type-kwargs
branch
from
9b8fc55 to
06bb7fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this makes two sets of distinct changes
This is currently based on #9594, and that should be reviewed and merged first.
This does not fix all the type issues in the gnome module, I'll follow this up with another series to address that separately, but this does get us complete typed_pos_args and typed_kwargs coverage