ValaCompiler: only emit '--debug' in debug build.#5690
Merged
nirbheek merged 1 commit intomesonbuild:masterfrom Jul 20, 2019
Merged
ValaCompiler: only emit '--debug' in debug build.#5690nirbheek merged 1 commit intomesonbuild:masterfrom
nirbheek merged 1 commit intomesonbuild:masterfrom
Conversation
|
I'm not a Vala guy, but I agree it looks like it was a mistake in #3489 and I think the fix here is correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently '--debug' is always emitted for Vala regardless of the build type.
From what I can see this has been introduced by #3489 and it does not look like the intended behavior (I could be wrong of course).