Skip to content

gnome.generate_gir: refactor and allow passing multiple libraries#4000

Merged
jpakkane merged 2 commits intomesonbuild:masterfrom
MathieuDuponchelle:gir_multiple_libs
Aug 12, 2018
Merged

gnome.generate_gir: refactor and allow passing multiple libraries#4000
jpakkane merged 2 commits intomesonbuild:masterfrom
MathieuDuponchelle:gir_multiple_libs

Conversation

@MathieuDuponchelle
Copy link
Contributor

This addresses #3688 , some significant refactoring is done in a first commit, and the functionality implemented in the second.

The method was getting too long and difficult to make sense
of, this should make maintaining and updating it a bit easier.
@nirbheek nirbheek self-assigned this Aug 11, 2018
Copy link
Member

@nirbheek nirbheek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Since this adds a new feature, it requires @jpakkane's review.

@nirbheek nirbheek added this to the 0.48.0 milestone Aug 11, 2018
@jpakkane jpakkane merged commit 9b3671e into mesonbuild:master Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants