Document system() == "android" as a fully supported value#15510
Merged
eli-schwartz merged 1 commit intomesonbuild:masterfrom Feb 1, 2026
Merged
Document system() == "android" as a fully supported value#15510eli-schwartz merged 1 commit intomesonbuild:masterfrom
eli-schwartz merged 1 commit intomesonbuild:masterfrom
Conversation
eli-schwartz
approved these changes
Feb 1, 2026
Member
eli-schwartz
left a comment
eli-schwartz
left a comment
There was a problem hiding this comment.
Thanks, this looks reasonable.
In mesonbuild#6233 the "android" system name was documented as "subject to change". The main argument for this was that there was no clear reference for what the value "should" be, because most Android builds are cross-compiling, and Python's `platform.system` is not used. At that time, Python didn't officially support Android anyway. However, Python has supported Android since version 3.13, which came out more than a year ago, and it now defines "Android" as a possible value of `platform.system`.
Member
|
Updated commit message to include the details from the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #6233 the "android"
systemname was documented as "subject to change". The main argument for this was that there was no clear reference for what the value "should" be, because most Android builds are cross-compiling, and Python'splatform.systemis not used. At that time, Python didn't officially support Android anyway.However, Python has supported Android since version 3.13, which came out more than a year ago, and it now defines "Android" as a possible value of
platform.system. In this context, I've successfully built NumPy and several other Meson-based Python packages that depend on it, and never had to make any changes to Meson itself (see the PRs linked to mesonbuild/meson-python#824).So I think the time has come for Meson to say that this value is no longer subject to change, and it's safe for people to rely on it.