Skip to content

Add local_program() function #15303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add local_program() function #15303

wants to merge 11 commits into from
+440 −191

Conversation

@xclaesse
Copy link
Member

@xclaesse xclaesse commented Nov 25, 2025

No description provided.

@xclaesse xclaesse mentioned this pull request Nov 25, 2025
Open
@bonzini
Copy link
Collaborator

bonzini commented Nov 25, 2025

A couple things that are missing in this PR:

  • creating the base class and then keeping the Union in most of the annotations is confusing
  • LocalProgram.get_command() cannot work (and therefore BaseProgramHolder.cmd_array_method() is broken)
  • BaseProgram is missing the for_machine field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mensinda mensinda Awaiting requested review from mensinda mensinda is a code owner

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xclaesse @bonzini