make the testsuite handle MSYS2's addition of cmd #13915
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some reason, recent version of MSYS2 is shipped with /usr/bin/cmd which makes the test fail
Member
This is easily enough done by reviewing patch-by-patch and merging what is currently ready -- though I actually had a review comment on those independent changes and the other PR also attempts to fix the CI that is failing in this PR at the moment (macos). Let's keep the discussion on the test suite changes in one PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains commits c21706e, 4d7de83 pulled from #13886.
With all the workflow runs currently consistently failing on 'msys' I think it may be worthwhile to look at these changes independently from the rest of that PR (which may or may not actually be a Python regression).
If the workflow runs can work reliably again, checks on PRs can sensibly provide feedback again.