Python: fix limited API logic under GCC on Windows#13379
Merged
eli-schwartz merged 2 commits intomesonbuild:masterfrom Jul 3, 2024
Merged
Python: fix limited API logic under GCC on Windows#13379eli-schwartz merged 2 commits intomesonbuild:masterfrom
eli-schwartz merged 2 commits intomesonbuild:masterfrom
Conversation
Member
Maybe: |
Contributor
Author
29d30fa to
ebf446b
Compare
Contributor
Author
|
Updated commit message as suggested. The fix is much clearer now in the log. |
|
Thanks for the quick fix! Is there an easy way to test this before the next RC? Preferably on GH actions, as I don't have easy access to a Windows machine. |
Member
(somewhere in the "before" actions for cibuildwheel, I presume.) |
|
That did the trick. It's working for me: https://github.com/nasa-gcn/hpx/actions/runs/9768042891/job/26964677305?pr=21 Thanks! |
|
Worked for me too! Thanks! |
They have recently upgraded to libgcrypt 1.11 and it has inherited the gpg suite migration to pkg-config.
When building a limited API module on Windows the library to link with should be python3.dll, not python3X.dll. This was already the case for non-GCC, but should have been the case unconditionally.
ebf446b to
8b757b1
Compare
Member
|
Just rerunning CI with a commit to get the cygwin runner passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building a limited API module on Windows with GCC the library to link with should be python3.dll, not python3X.dll.