Skip to content

Comments

Python: fix limited API logic under GCC on Windows#13379

Merged
eli-schwartz merged 2 commits intomesonbuild:masterfrom
amcn:python-gcc-win32-limited-api
Jul 3, 2024
Merged

Python: fix limited API logic under GCC on Windows#13379
eli-schwartz merged 2 commits intomesonbuild:masterfrom
amcn:python-gcc-win32-limited-api

Conversation

@amcn
Copy link
Contributor

@amcn amcn commented Jul 2, 2024

When building a limited API module on Windows with GCC the library to link with should be python3.dll, not python3X.dll.

@amcn amcn requested a review from jpakkane as a code owner July 2, 2024 21:04
@eli-schwartz
Copy link
Member

When building a limited API module on Windows with
GCC the library to link with should be python3.dll,
not python3X.dll.

Maybe:

When building a limited API module on Windows the library
to link with should be python3.dll, not python3X.dll. This was
already the case for non-GCC, but should have been the case
unconditionally.

@amcn
Copy link
Contributor Author

amcn commented Jul 2, 2024

Fingers crossed this fixes the issue that both @sdimovv and @lpsinger have encountered during the discussion of #13171.

Feedback very welcome.

@amcn amcn force-pushed the python-gcc-win32-limited-api branch from 29d30fa to ebf446b Compare July 2, 2024 21:11
@amcn
Copy link
Contributor Author

amcn commented Jul 2, 2024

Updated commit message as suggested. The fix is much clearer now in the log.

@astro-stan
Copy link

Thanks for the quick fix!

Is there an easy way to test this before the next RC? Preferably on GH actions, as I don't have easy access to a Windows machine.

@eli-schwartz
Copy link
Member

eli-schwartz commented Jul 2, 2024

pip install git+https://github.com/amcn/meson@python-gcc-win32-limited-api

(somewhere in the "before" actions for cibuildwheel, I presume.)

@lpsinger
Copy link

lpsinger commented Jul 2, 2024

@astro-stan
Copy link

Worked for me too!

Thanks!

eli-schwartz and others added 2 commits July 2, 2024 19:52
They have recently upgraded to libgcrypt 1.11 and it has inherited the
gpg suite migration to pkg-config.
When building a limited API module on Windows the library
to link with should be python3.dll, not python3X.dll. This was
already the case for non-GCC, but should have been the case
unconditionally.
@eli-schwartz eli-schwartz force-pushed the python-gcc-win32-limited-api branch from ebf446b to 8b757b1 Compare July 2, 2024 23:53
@eli-schwartz
Copy link
Member

Just rerunning CI with a commit to get the cygwin runner passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants