Use posix paths in devenv's PATH variable#12309
Open
DFOVIT wants to merge 1 commit intomesonbuild:masterfrom
Open
Use posix paths in devenv's PATH variable#12309DFOVIT wants to merge 1 commit intomesonbuild:masterfrom
DFOVIT wants to merge 1 commit intomesonbuild:masterfrom
Conversation
Member
|
That's not the only place we have paths, they'll all have to be fixed then... But that sounds like a vscode issue, they should not assume that env file is escaped. Or we could also |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the devenv dumped for vscode on windows contains windows paths :
PATH="C:\dev\tools\meson\test cases\unit\90 devenv\builddir\;C:\dev\tools\meson\test cases\unit\90 devenv\builddir\subprojects\sub"which will fail when a directory start with a n for example :
c:\this\will\not\work.When using posix paths, vscode is happy.
This is a subset that @amyspark kindly agreed to add to #12194