Skip to content

Conversation

@jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Sep 21, 2022

I continue seeing it in the wild.

@eli-schwartz
Copy link
Member

CI failure is very relevant.

The docs generator was previously restricted to ASCII,
preventing the use of nicer typography characters.
Since ASCII is a subset of UTF-8, expanding should be safe.
@eli-schwartz
Copy link
Member

I do not want you to use unicode in the docs, NACK to the first commit. :)

@tristan957
Copy link
Member

unicode is already used in the docs, for instance in the reference tables. No idea why we aren't just using ^1 there instead of superscript 1

@eli-schwartz
Copy link
Member

Idk about that, but I do know that frivolously using "typographically correct" "annoying" quotes is... annoying. And it's also frivolous.

So anything that catches them and makes them error out is good in my book. Now if only we could remove them from the Unicode standard...

I think in general if your documentation relies on Unicode then you need to do some deep introspection on why you think you need it and whether that's in fact true. It probably isn't.

@tristan957
Copy link
Member

image

@tristan957
Copy link
Member

tristan957 commented Sep 22, 2022

I also hate unicode quotes, but I don't think automatic detection is a reason to forbid all of unicode. That is just a reason to force use of regular quotes

eli-schwartz added a commit to eli-schwartz/meson that referenced this pull request Sep 28, 2022
…ut it

We need to support cases where the library might be called "foo.so" and
therefore we check for exact matches too. But this also allows
`cc.find_library('libfoo')` to find libfoo.so, which is strange and
won't work in many cases. Emit a warning when this happens.

Fixes mesonbuild#10838
@eli-schwartz
Copy link
Member

Anyway this approach is totally wrong, I submitted a PR to do this correctly, by warning about it instead of burying it in docs where no one will see it.

jpakkane pushed a commit that referenced this pull request Sep 28, 2022
…ut it

We need to support cases where the library might be called "foo.so" and
therefore we check for exact matches too. But this also allows
`cc.find_library('libfoo')` to find libfoo.so, which is strange and
won't work in many cases. Emit a warning when this happens.

Fixes #10838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants